Fix Important Crash Issue With Custom Generator World (Datapack/Plugins)

[Euphillya]

Fix #6028

[electronicboy]

That is only one of the several dozen of these, and I question why we're getting an empty list here, this doesn't seem like a real fix?

[Euphillya]

In fact, in the TreeFeacture.java file, the condition:

if (bl && (!set.isEmpty() || !set2.isEmpty())) {

asks if one or the other is empty, set2 is not empty but "set " happens to be. We can limit ask to check the 2 at the same time.

[electronicboy]

Yarn shows that as

        if (!bl || set.isEmpty() && set2.isEmpty()) {
            return false;
        }

Which looks more accurate to the intent there, yay decompilers...

I'm somewhat confused on this one, are there any "trees" without leaves? Some of the populators seem to care about that though, which makes me wonder about some of the reports, is something borking up the chain I wonder

[Euphillya]

With datapacks and plugins that change the generation of biomes, it is possible to have trees without leaves as in my case that I had with my server (datapack).

[Euphillya]

I discovered that the bug is also on the file: CocoaDecorator, therefore changing the condition is much better directly.

[Euphillya]

up

[electronicboy]

I'm still not sure that this is actually a correct fix, does tree gen still work properly with this? For me, this screams that it would prevent generation in cases for trees which don't have leaves and logs, which while it would fix the crash, it would prevent those things from generating

(Standard vanilla trees would be fine, but, the trees which trigger this crash won't be generated as the logic is not being ran, the sad truth here is that the best option is probs to fix the actual issues)

[Euphillya]

Since apparently this is not the right solution, I close this PR.