Skip to content

Improve EntityTransformEvent cancellation handling#6465

Closed
Machine-Maker wants to merge 1 commit into
PaperMC:masterfrom
Machine-Maker:fix/EntityTransformEvent-cancellation
Closed

Improve EntityTransformEvent cancellation handling#6465
Machine-Maker wants to merge 1 commit into
PaperMC:masterfrom
Machine-Maker:fix/EntityTransformEvent-cancellation

Conversation

@Machine-Maker
Copy link
Copy Markdown
Member

Saw the spigot issue, and decided to look around elsewhere for oddities with cancelling EntityTransformEvent, and as usual, there was an issue where Villager's deaths would be logged if it was cancelled, and they wouldn't take lightning damage if it was cancelled.

@Machine-Maker Machine-Maker requested review from a team as code owners August 22, 2021 04:17
Comment thread patches/server/0750-Improve-EntityTransformEvent-cancellation-handling.patch Outdated
@Machine-Maker Machine-Maker force-pushed the fix/EntityTransformEvent-cancellation branch from 6a7936d to 1ad1ee9 Compare August 25, 2021 20:42
@Machine-Maker
Copy link
Copy Markdown
Member Author

Rebased after upstream fixed just 1 of the issues with EntityTransformEvent

@stale
Copy link
Copy Markdown

stale Bot commented Oct 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Machine-Maker Machine-Maker force-pushed the fix/EntityTransformEvent-cancellation branch from 1ad1ee9 to e63c30b Compare October 25, 2021 02:41
@Machine-Maker Machine-Maker force-pushed the fix/EntityTransformEvent-cancellation branch from e63c30b to f01a67d Compare December 24, 2021 05:28
@Machine-Maker
Copy link
Copy Markdown
Member Author

Rebased for 1.18.1

@stale
Copy link
Copy Markdown

stale Bot commented Feb 22, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Machine-Maker Machine-Maker force-pushed the fix/EntityTransformEvent-cancellation branch from f01a67d to 2df0cd7 Compare February 22, 2022 18:14
@stale stale Bot removed the resolution: stale label Feb 22, 2022
@stale
Copy link
Copy Markdown

stale Bot commented Apr 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Machine-Maker Machine-Maker force-pushed the fix/EntityTransformEvent-cancellation branch from 2df0cd7 to b9c2dc2 Compare April 24, 2022 04:14
@stale stale Bot removed the resolution: stale label Apr 24, 2022
@Machine-Maker
Copy link
Copy Markdown
Member Author

Rebased for 1.18.2

@stale
Copy link
Copy Markdown

stale Bot commented Jun 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link
Copy Markdown

stale Bot commented Jul 2, 2022

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.

@Machine-Maker Machine-Maker force-pushed the fix/EntityTransformEvent-cancellation branch from b9c2dc2 to 858f1d9 Compare December 23, 2022 01:45
@Machine-Maker
Copy link
Copy Markdown
Member Author

Rebased for 1.19.3

@Warriorrrr Warriorrrr moved this from Awaiting final testing to Waiting For Author in Paper PR Queue Mar 5, 2025
@kennytv kennytv added the pre-softspoon: never rebased Pre-hardfork pull requests that were not re-opened with the new main branch label Mar 23, 2025
@kennytv kennytv deleted the branch PaperMC:master March 23, 2025 19:15
@kennytv kennytv closed this Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pre-softspoon: never rebased Pre-hardfork pull requests that were not re-opened with the new main branch pre-softspoon

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants