Add BlockDropResourcesEvent and EntityBreakBlockEvent#6771
Closed
qixils wants to merge 2 commits into
Closed
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
a080269 to
0ddbfb6
Compare
Contributor
Author
|
Rebased (and fixed up) for 1.18.2 |
Adds events that are called when a block drops resources (items) into the world as a result of being broken.
0ddbfb6 to
f24a646
Compare
Machine-Maker
requested changes
Mar 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands upon #4989 (cc @Machine-Maker) by:
Use cases:
note: blocks broken by players seem to not exist at time of event calling (i blame all the weirdly player-specific block-related events in bukkit), will investigate sooni identified the logic that leads to this behavior but it unfortunately doesn't seem workaround-able so i opted to just include a snapshot of the blockstate inside the event instead which is Good Enough