Add method for getting a sound's subtitle key#7232
Closed
Machine-Maker wants to merge 1 commit into
Closed
Conversation
Machine-Maker
force-pushed
the
feature/subtitle-i18n-keys
branch
5 times, most recently
from
845a24d to
009049c
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Machine-Maker
force-pushed
the
feature/subtitle-i18n-keys
branch
from
009049c to
b4ad625
Compare
Machine-Maker
force-pushed
the
feature/subtitle-i18n-keys
branch
from
b4ad625 to
98eafcf
Compare
Machine-Maker
force-pushed
the
feature/subtitle-i18n-keys
branch
from
98eafcf to
eae690b
Compare
Member
Author
|
Rebased for 1.19.2. Currently, this uses the |
Member
|
It shouldn't be a big deal since it's gitignored. Maybe try building and then changing a patch, reapplying patches and building again with --console=verbose to see if it reruns the task |
kennytv
added
the
pre-softspoon: never rebased
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soooooo since the client uses one of the many resources it downloads for associated a sound with a subtitle key, the test makes a request to mojangs resources api. idk how good that is, maybe the test should be disabled most of the time or smth. But, it works. I also wrote a function that generates the big switch statement thats commented out of the test by default cause most of the time it doesnt need to be run.