Better menu property API#7251
Closed
Machine-Maker wants to merge 1 commit into
Closed
Conversation
Member
Member
Author
|
Literally every class I ever add now, is gonna be called |
5c47842 to
7476551
Compare
Member
Author
|
Should be good, finished adding javadocs |
7476551 to
fc60229
Compare
Owen1212055
approved these changes
Mar 9, 2022
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
fc60229 to
4ad1772
Compare
Member
Author
|
Rebased for 1.18.2 |
4ad1772 to
f19ecf9
Compare
836cc84 to
cbd25fc
Compare
Member
Author
|
Rebased and updated for 1.20.4. Renamed type to MenuProperty |
cbd25fc to
e7dd918
Compare
e7dd918 to
18eb96f
Compare
Member
Author
|
No longer needed because there are subinterfaces for each view type (like EnchantmentView, BrewingStandView, etc.). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Needs a bunch of javadoc comments stillThe old property system had a few big issues (
InventoryView$Property),I changed it into a class format, with a generic for the value type that's converted to an integer in the server impl.