Fix StoredEnchants reordering inconsistently#7335
Closed
Machine-Maker wants to merge 1 commit into
Closed
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Machine-Maker
force-pushed
the
fix/stored-enchant-reordering
branch
from
9254a92 to
b744bed
Compare
Member
Author
|
Rebased for 1.18.2 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Machine-Maker
force-pushed
the
fix/stored-enchant-reordering
branch
from
b744bed to
b8bea81
Compare
Member
Author
|
Rebased and updated |
This was referenced Mar 26, 2023
Member
|
Closing in favour of #8711 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6437
Tested using the reproduction steps outlined in above issue.
I think its better to not reorder stored enchants, as the order does have an effect on anvil usage. It's also a smaller diff, less to maintain, and will change 0 existing items, only newly created ones as LinkedHashSets keep the order from the EnchantmentMap but don't change it.