Call bucket events for cauldrons#7486
Merged
lynxplay merged 3 commits intoSep 28, 2024
Merged
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Machine-Maker
force-pushed
the
feature/cauldron-bucket-events
branch
from
5ce7dbf to
5ce675e
Compare
Member
Author
|
Rebased for 1.18.2 |
Machine-Maker
force-pushed
the
feature/cauldron-bucket-events
branch
from
5ce675e to
81ff41c
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Machine-Maker
force-pushed
the
feature/cauldron-bucket-events
branch
from
81ff41c to
2e161e0
Compare
Member
Author
|
Rebased for 1.19 |
Machine-Maker
force-pushed
the
feature/cauldron-bucket-events
branch
from
2e161e0 to
6471538
Compare
Member
Author
|
Rebased for 1.21.1 |
Machine-Maker
force-pushed
the
feature/cauldron-bucket-events
branch
from
6471538 to
4719334
Compare
lynxplay
approved these changes
Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the BucketFill and Empty events should be called for cauldron interactions.
I had to create a bit of a hack-around to track the BlockFace, that's what the static field on AbstractCauldronBlock is, but I think the only alternative would be to overload the interact method in CauldronInteraction which would mean a way bigger diff.