Skip to content

Add DispenserReplaceItemEvent#7530

Closed
xDec0de wants to merge 3 commits into
PaperMC:masterfrom
xDec0de:master
Closed

Add DispenserReplaceItemEvent#7530
xDec0de wants to merge 3 commits into
PaperMC:masterfrom
xDec0de:master

Conversation

@xDec0de
Copy link
Copy Markdown

@xDec0de xDec0de commented Mar 3, 2022

Currently handled for any bucket and bottle type, which should be all items that can be replaced on a dispenser as far as I know. This event could be used for servers with a rarity system on items (As mine), as currently I had to use the normal dispense event and delay 1 tick a loop through the dispenser inventory to change the item lore.

Currently handled for any bucket and bottle type, which should be all items that can be replaced on a dispenser as far as I know. This event could be used for servers with a rarity system on items (As mine), as currently I had to use the normal dispense event and delay 1 tick a loop through the dispenser inventory to change the item lore.
@xDec0de xDec0de requested a review from a team as a code owner March 3, 2022 01:59
Comment thread patches/server/0879-Add-DispenserReplaceItemEvent.patch Outdated
Comment thread patches/server/0879-Add-DispenserReplaceItemEvent.patch Outdated
@Machine-Maker
Copy link
Copy Markdown
Member

I would prefer adding a "replacement stack" field to the existing BlockDispenseEvent over adding a whole event for this.

This also slightly (or significantly) conflicts with #7513 I think.

@xDec0de
Copy link
Copy Markdown
Author

xDec0de commented Mar 3, 2022

I would prefer adding a "replacement stack" field to the existing BlockDispenseEvent over adding a whole event for this.

This also slightly (or significantly) conflicts with #7513 I think.

That makes sense, now that you mention it I'm not really sure as why I decided to go with a whole new event as a solution, also, yeah, I saw that PR but wasn't really sure on how to work on it because it isn't merged. I could add a field but doing so will result on another conflict I guess.

@xDec0de xDec0de removed the request for review from a team March 4, 2022 00:35
@stale
Copy link
Copy Markdown

stale Bot commented May 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@electronicboy
Copy link
Copy Markdown
Member

#7513 - not sure where this stands in regards to this PR and what needs doing here (too brain gone right now)

@stale stale Bot removed the resolution: stale label May 4, 2022
@Owen1212055
Copy link
Copy Markdown
Member

Are you planning on perhaps adding this to the already pre-existing event instead of making a new one? The PR mentioned only covers a specific use case (bottles), and I feel like a generic solution like this one is better.

@Owen1212055
Copy link
Copy Markdown
Member

Superseded by #8660, thank you regardless for your contribution. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

5 participants