Allow usage of MiniMessage in server configuration files#7549
Allow usage of MiniMessage in server configuration files#7549Astralchroma wants to merge 1 commit into
Conversation
NoahvdAa
left a comment
There was a problem hiding this comment.
Congrats on making your first paper PR, welcome!
|
as I said on discord, really we should consilidate all of the messages into a singular patch file, rather than this patch which tweaks all of the old options, we'd also have to look into migrating bukkits messages over, but, am not sure 100% on that's based done without the config migration stuff |
Machine-Maker
left a comment
There was a problem hiding this comment.
Ok, basically all of this should be done in the patch that makes these changes originally.
So I have been working on doing this, but when it comes to messages added by Spigot, that has to be done in a new patch, which is fine, but... patch 147 depends on one of these messages, so the patch has to go before 147. How would I go about adding a patch before an existing patch? |
I wouldn't put it right before, I'd maybe put it in the adventure patch. @kashike might want to weigh in on that. but to add a patch, just interactive rebase to the commit you want to add a patch after, and then just make a new commit, and then continue rebasing. |
|
So after basically rewriting this PR, usage of MiniMessage is no longer optional, I will add code to automatically convert Legacy messages to MiniMessage in a bit. I have also changed everything to be done as part of previous patches. Which was very annoying and took forever. |
|
Not dead, just have alot of things to be doing, I will get back to this later. |
|
Closed because I am not sure how to go about handling configuration migration, so I will leave someone else to deal with it. |
Allows the messages in
bukkit.yml,spigot.yml, andpaper.ymlto be written using the MiniMessage format.In order to maintain compatibility with existing configuration files the optionconfiguration-uses-minimessageoption has been added topaper.yml. This option defaults tofalsefor any configuration files before config version 26.New configuration files use MiniMessage by default, and the default messages have been converted to use it.
This also includes 2 minor API changes:
Bukkit#getPermissionMessagewhich returned aStringhas been deprecated in favor ofBukkit#permissionMessagewhich returns aComponentServer#getPermissionMessagewhich returned aStringhas been deprecated in favor ofServer#permissionMessagewhich returns aComponentCloses #7520