Clean up removed tags after datapack unload#7634
Closed
Machine-Maker wants to merge 1 commit into
Closed
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Machine-Maker
force-pushed
the
fix/tags-unloading
branch
from
42a0255 to
06312d3
Compare
Machine-Maker
changed the title
Machine-Maker
force-pushed
the
fix/tags-unloading
branch
from
06312d3 to
e587db1
Compare
Member
Author
|
Turns out the client does still maintain a reference to the old tag, even if you leave the server and join back. The protocol just doesn't support removing tags. It's possible its worth fixing it just on the server as at least the server-side functionality which might depend on that tag. Unsure tho. |
kennytv
added
the
pre-softspoon: never rebased
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see patch description
There is this mojira issue, but its not exactly what this fixes since they are reporting it as a client issue (which it probably still is)