Add more datapack API#7636
Closed
NoahvdAa wants to merge 1 commit into
Closed
Conversation
4drian3d
reviewed
Mar 20, 2022
NoahvdAa
force-pushed
the
feature/more-datapack-api
branch
from
a89875b to
8057c37
Compare
Machine-Maker
approved these changes
Mar 22, 2022
NoahvdAa
force-pushed
the
feature/more-datapack-api
branch
from
8057c37 to
ca0d092
Compare
MiniDigger
approved these changes
Mar 22, 2022
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
NoahvdAa
force-pushed
the
feature/more-datapack-api
branch
4 times, most recently
from
2d37aa2 to
3bb035d
Compare
Member
Author
|
Rebased. |
NoahvdAa
force-pushed
the
feature/more-datapack-api
branch
from
3bb035d to
48f10d8
Compare
Member
Author
|
Rebased for 1.19! Builds are failing because of a javadoc.io outage (nothing to do with the PR) |
NoahvdAa
force-pushed
the
feature/more-datapack-api
branch
from
48f10d8 to
4f4817f
Compare
Member
Author
|
Rebased. |
Member
|
Can you rebase this? |
Machine-Maker
requested changes
Mar 4, 2023
| + * @return the newly loaded pack | ||
| + */ | ||
| + @Nullable | ||
| + default Datapack loadDatapack(@NotNull String name, @NotNull File file) throws FileNotFoundException, IOException { |
| + * @return the newly loaded pack | ||
| + */ | ||
| + @Nullable | ||
| + Datapack loadDatapack(@NotNull String name, @NotNull File file, boolean enable) throws FileNotFoundException, IOException; |
| + Validate.notNull(file, "File cannot be null"); | ||
| + Pack pack; | ||
| + try { | ||
| + pack = Pack.createUnsafe(name, false, createSupplier(file), this.repository.constructor, Pack.Position.TOP, PackSource.SERVER); |
Member
There was a problem hiding this comment.
Is TOP really the best option here? Unless I'm misunderstanding here, that means it will be loaded first after the reload versus last. I would think it should be loaded after all the other packs are reloaded.
kennytv
added
the
pre-softspoon: never rebased
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤦 Finger slipped, accidentally typed
git push -fdinstead ofgit push -fand Github won't let me reopen the PR since I force pushed to it...Original PR @ #6711, fixes #4654