Improve LootContext API#7655
Closed
Machine-Maker wants to merge 1 commit into
Closed
Conversation
Machine-Maker
added
for: future
Machine-Maker
force-pushed
the
feature/better-lootcontext-api
branch
from
afa7d3c to
d8dda14
Compare
Machine-Maker
force-pushed
the
feature/better-lootcontext-api
branch
from
d8dda14 to
d42280f
Compare
Machine-Maker
removed
the
for: future
Member
Author
|
This is just waiting on the damage source API, and then will be complete. |
Machine-Maker
force-pushed
the
feature/better-lootcontext-api
branch
from
d42280f to
a16d6b6
Compare
Member
Author
|
Rebased for 1.20.4, still blocked for damage source API |
CraftBukkit added new DamageSource API (https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/commits/be72314ca31c7628c9a4cf0cba695b2d7c1cee47) |
Machine-Maker
force-pushed
the
feature/better-lootcontext-api
branch
from
a16d6b6 to
82701e1
Compare
Machine-Maker
removed
the
status: blocked
Member
Author
|
DamageSource API is now in Paper, so this PR is good to go. |
Machine-Maker
force-pushed
the
feature/better-lootcontext-api
branch
from
82701e1 to
4fd115f
Compare
Machine-Maker
force-pushed
the
feature/better-lootcontext-api
branch
from
4fd115f to
ff6babe
Compare
|
up |
kennytv
added
the
pre-softspoon: never rebased
Machine-Maker
removed
the
pre-softspoon: never rebased
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be compatible with legacy LootContexts too. upstream has some jank logic to try and fill nms contexts with just the few fields on the api LootContext.
Fixes #9684