Fix setting invalid direction state prop in UpgradeData#7781
Closed
Machine-Maker wants to merge 1 commit into
Closed
Fix setting invalid direction state prop in UpgradeData#7781Machine-Maker wants to merge 1 commit into
Machine-Maker wants to merge 1 commit into
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Machine-Maker
force-pushed
the
fix/upgrade-data
branch
from
34973b1 to
d8b5bec
Compare
Member
Author
|
Rebased for 1.19 |
Owen1212055
approved these changes
Oct 22, 2022
Member
|
See: #7764 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #7764 although I don't know how to test it exactly. Not 100% on the logic that makes these run in the first place. Other fixers there have a isHorizontal check which supports this one having one too.