Fix section symbols not working in logger#7873
Closed
JRoy wants to merge 1 commit into
Closed
Conversation
|
i already tryed this and they said no no no no no #7767 |
|
so not "unintended regression" |
Member
Author
this fix comes from jmp and is better than your pr |
|
on discord he sayd it is not accepted no matter how good the code. ik mine is bad when i look back. even w/ toggle. gl |
mdcfe
approved these changes
Jun 7, 2022
Spottedleaf
requested review from
Spottedleaf
and removed request for
Spottedleaf
Member
Author
|
@limbo-app ready |
electronicboy
previously approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression in the hex pattern converter that caused a breaking change unintended before hard fork.
cc @broccolai @Spottedleaf
bcc @jpenilla