Skip to content

Expose CommandSender for command blocks#8103

Closed
Machine-Maker wants to merge 1 commit into
PaperMC:masterfrom
Machine-Maker:feature/command-block-sender
Closed

Expose CommandSender for command blocks#8103
Machine-Maker wants to merge 1 commit into
PaperMC:masterfrom
Machine-Maker:feature/command-block-sender

Conversation

@Machine-Maker
Copy link
Copy Markdown
Member

@Machine-Maker Machine-Maker commented Jul 6, 2022

No description provided.

@Machine-Maker Machine-Maker requested a review from a team as a code owner July 6, 2022 02:04
@Machine-Maker Machine-Maker force-pushed the feature/command-block-sender branch from 0a81eef to 66db455 Compare July 6, 2022 02:04
Copy link
Copy Markdown
Member Author

@Machine-Maker Machine-Maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From jmp:
only issue with that PR is some weird stuff could happen if you use the sender after the command block is removed
might want to add better exceptions/checks
also when a command block executes commands it does some extra logic, may or may not want to call into that or have a separate method that does, idk

@Machine-Maker
Copy link
Copy Markdown
Member Author

@jpenilla

only issue with that PR is some weird stuff could happen if you use the sender after the command block is removed might want to add better exceptions/checks

We don't have checks for this on entities right? You can hold a reference to an entity that no longer exists on the world but it can be used as a CommandSender.

also when a command block executes commands it does some extra logic, may or may not want to call into that or have a separate method that does, idk

I think that should be a separate method. Basically a method that just directly runs the command execution logic directly. Not adding that here.

@Warriorrrr Warriorrrr moved this from Awaiting final testing to Waiting For Author in Paper PR Queue Mar 5, 2025
@kennytv kennytv added the pre-softspoon: never rebased Pre-hardfork pull requests that were not re-opened with the new main branch label Mar 23, 2025
@kennytv kennytv deleted the branch PaperMC:master March 23, 2025 19:15
@kennytv kennytv closed this Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pre-softspoon: never rebased Pre-hardfork pull requests that were not re-opened with the new main branch pre-softspoon

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants