Expose CommandSender for command blocks#8103
Conversation
0a81eef to
66db455
Compare
Machine-Maker
left a comment
There was a problem hiding this comment.
From jmp:
only issue with that PR is some weird stuff could happen if you use the sender after the command block is removed
might want to add better exceptions/checks
also when a command block executes commands it does some extra logic, may or may not want to call into that or have a separate method that does, idk
We don't have checks for this on entities right? You can hold a reference to an entity that no longer exists on the world but it can be used as a CommandSender.
I think that should be a separate method. Basically a method that just directly runs the command execution logic directly. Not adding that here. |
No description provided.