Implement CreatureSpawnEvent.SpawnReason.SPAWNER_BUCKET#8236
Closed
Doc94 wants to merge 1 commit into
Closed
Conversation
Contributor
|
I think just BUCKET or ENTITY_BUCKET would be better than SPAWNER_BUCKET. The only other two entries with "spawn" in their name are actually named like that in game. E.g. the Spawner Block or for example "Blaze Spawn Egg" |
Member
|
See #4361 (comment). In a similar situations, we don't change a Bee's SpawnReason when they leave a beehive, it keeps the previous one. A similar thing should be applied here. It can fallback to some other reason if it doesn't exist. (I think spawn egg is still fine for that) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This close #8234 adding a new SpawnReason for entity spawned using a bucket.
The name of the reason is based in another things with "spawn" logic like SPAWNER_EGG