Fix command function perm checking#8602
Closed
Machine-Maker wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Apparently opened another PR that makes this change... idk how I ended up opening 2 prs separated by 6 months that fix the same problem, but whatever. Was done in #9411 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a command function tried to parse a command above it's configured permission level (see
function-permission-levelin `server.properties), it would throw a UOE due to a badly structured conditional in CommandSourceStack from upstream. Now instead of a UOE it throws an unknown command error, as it would in vanilla on an invalid command.