Improve vibration events#8636
Closed
Machine-Maker wants to merge 1 commit into
Closed
Conversation
Adds EntityReceiveGameEvent and expands BlockReceiveGameEvent
Machine-Maker
force-pushed
the
feature/better-game-event-events
branch
from
4bbb3d8 to
c516c1f
Compare
Member
Author
|
Updated for 1.19.4 and removed the "vibration" part of the event. GameEvent are not equivalent to vibrations. There could be a use for a future sub event of the block/entity events for vibration specifically, but this isn't that PR. |
kennytv
added
the
pre-softspoon: never rebased
Machine-Maker
removed
the
pre-softspoon: never rebased
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds EntityReceiveGameEvent and expands BlockReceiveGameEvent
BlockReceiveGameEvent was not called for all block listeners, and was called for entity listeners. This separates them out into two events and adds missing event calls. It also adds more api for bypassing line of sight/occlusion checks (not sure what to call that).
Still needs testing, but wanted to open this while I did that.