Conversation
Owen1212055
left a comment
Owen1212055
left a comment
There was a problem hiding this comment.
This doesn't seem to work?
Tested and it always returns an empty set.
Machine-Maker
force-pushed
the
fix/creativecategory-api
branch
from
76e85a5 to
7a238f2
Compare
|
It'd help if I actually pushed from my local repo... |
|
Would also be nice if the Materials in the Material Enum would be sortet the way the new search tab in the creativ inventory is sortet. So the wood is grouped etc. |
|
The material enum is most likely being deprecated either for 1.20 or the next major update, not really worth it. Even so, I don't really think the order of fields is important at all. Also, some materials are in multiple categories, so not sure how that would factor into the field order. |
|
In the search bar, more or less all items are contained. And they are sortet in the new way, which is much more convinient. When I list items, I would really like this way of order over the old one. |
Machine-Maker
force-pushed
the
fix/creativecategory-api
branch
from
7a238f2 to
e9a584f
Compare
Machine-Maker
force-pushed
the
fix/creativecategory-api
branch
from
e9a584f to
38c83f7
Compare
| +@DefaultQualifier(NonNull.class) | ||
| +public final class PaperCreativeCategory { | ||
| + | ||
| + public static final List<CreativeModeTab> BLOCK_TABS = CreativeModeTabs.allTabs().stream().filter(tab -> tab.getType() == CreativeModeTab.Type.CATEGORY).toList(); |
There was a problem hiding this comment.
CreativeModeTabs#streamAllTabs can be used here
|
Hey, any updates on this? Can't really fallback to the existing implementation since it's just a constant for all items. |
Iirc the creative categories are deprecated since they no longer exist on the server |
|
Gotcha, any way we could semi mimic it with tags? That's about the only half-baked solution that's really worked for us |
|
Mojang now stores this stuff in a registry on the server, the old method will be deprecated because things can be in more than 1 tab, though |
Warriorrrr
moved this from Awaiting final testing
to Waiting For Author
in Paper PR Queue
kennytv
added
the
pre-softspoon: never rebased
Machine-Maker
removed
the
pre-softspoon: never rebased
9 participants
Probably in the future this should be expanded to get all itemstacks in a specific category. It's not perfect system since ItemStacks are in categories now, so also a method to check if an ItemStack is in a specific category would be nice.
Fixes #8770