Added a config option for ticking markers#9034
Merged
Owen1212055 merged 8 commits intoPaperMC:masterfrom Apr 2, 2023
Merged
Conversation
MiniDigger
previously requested changes
Mar 24, 2023
Contributor
Author
Should be reverted. Sorry about that |
Machine-Maker
requested changes
Mar 24, 2023
Machine-Maker
approved these changes
Mar 25, 2023
Contributor
Author
|
@MiniDigger Any updates? |
Owen1212055
approved these changes
Apr 2, 2023
Owen1212055
force-pushed
the
marker-tick-config
branch
from
6b47319 to
f5ce84d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #8118 by adding a configuration option that allows the ticking of marker entities to be enabled and disabled. By default, marker ticking is disabled.
I had an old PR for this, but I didn't modify the patches correctly & the logic in one of the checks was wrong.