Added the ability to disable non-player markers#9048
Closed
poonkje112 wants to merge 5 commits into
Closed
Conversation
Machine-Maker
requested changes
Mar 27, 2023
poonkje112
force-pushed
the
feature/map-markers
branch
from
a653e17 to
3a65345
Compare
Warriorrrr
requested changes
Sep 8, 2023
| // If this cursor is for a player check visibility with vanish system | ||
| org.bukkit.entity.Player other = org.bukkit.Bukkit.getPlayerExact(name); // Spigot | ||
| if (other == null || player.canSee(other)) { | ||
| + if(!io.papermc.paper.configuration.GlobalConfiguration.get().misc.showMapMarkers && mapIcon.getType() != MapDecoration.Type.PLAYER) return; // Paper - Configurable map markers |
Member
There was a problem hiding this comment.
This will also need to be added to the CraftMapRenderer class
kennytv
added
the
pre-softspoon: never rebased
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8464