Skip to content

ignoring moved too quickly message for teleports#9257

Closed
NonSwag wants to merge 1 commit into
PaperMC:masterfrom
NonSwag:movement-fix
Closed

ignoring moved too quickly message for teleports#9257
NonSwag wants to merge 1 commit into
PaperMC:masterfrom
NonSwag:movement-fix

Conversation

@NonSwag
Copy link
Copy Markdown
Contributor

@NonSwag NonSwag commented Jun 3, 2023

I messed up my local branch commit history, so this is a copy of #9202

@NonSwag NonSwag requested a review from a team as a code owner June 3, 2023 21:31
Copy link
Copy Markdown
Member

@Machine-Maker Machine-Maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the justTeleported field getting reset to false anywhere that's gonna happen every tick. I'm not sure its appropriate for use here, can you explain about your reasoning for using it?

@NonSwag
Copy link
Copy Markdown
Contributor Author

NonSwag commented Jun 4, 2023

If I recall it correctly, it gets reset after the next movement packet comes in.
I've tested it with invalid movements and with teleports...
The teleports from the server did not get flagged as invalid movement, but the speed and clip cheats did.
But I will double-check for you and send the corresponding code.

Copy link
Copy Markdown
Member

@Owen1212055 Owen1212055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks fine, but, I am a little iffy since this seems to be an "anti-cheat" feature here.. so this may be a little delicate to change here.

Someone a little more familiar with this area should probably give a second opinion (anti cheat developers or what not?)

@NonSwag
Copy link
Copy Markdown
Contributor Author

NonSwag commented Jul 14, 2023

Is there any update about this?

@Owen1212055
Copy link
Copy Markdown
Member

The movement netcode is kinda delicate, hoping to get some other testing here.

@NonSwag
Copy link
Copy Markdown
Contributor Author

NonSwag commented Sep 10, 2023

I think this is obsolete (for developers) now with the introduction of the new PlayerFailMoveEvent

@NonSwag NonSwag closed this Sep 10, 2023
@NonSwag NonSwag deleted the movement-fix branch September 10, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants