Skip to content

fix bed placement bug#9431

Closed
outlineutils wants to merge 1 commit into
PaperMC:masterfrom
outlineutils:fix-bed-placement
Closed

fix bed placement bug#9431
outlineutils wants to merge 1 commit into
PaperMC:masterfrom
outlineutils:fix-bed-placement

Conversation

@outlineutils
Copy link
Copy Markdown

fix MC-123619

@outlineutils outlineutils requested a review from a team as a code owner July 1, 2023 02:25
@MiniDigger
Copy link
Copy Markdown
Member

this is a pretty big behavior change, what is your reasoning for wanting this fixed?

@DerEchtePilz
Copy link
Copy Markdown
Contributor

this is a pretty big behavior change, what is your reasoning for wanting this fixed?

I could imagine they want it to be fixed because it is a bug and it exists a long time.

@outlineutils
Copy link
Copy Markdown
Author

outlineutils commented Jul 1, 2023

People can place beds inside peoples faces in nether pvp when they are in a hole, forcing them into the crawling animation so they can't even pearl out, while dealing massive damage (1 bed kills in most cases). In older game versions this bug was present but wasn't an issue since you couldn't place beds unless you had two supporting blocks beneath it, but since that was removed this bug is now very easy to exploit. Since there's no practical use for this mechanic outside of cheesing pvp, and it's been acknowledged as a bug by mojang, I don't think there is any negative to fixing it.

@Machine-Maker
Copy link
Copy Markdown
Member

The mojira issue talks about all "multi block" blocks being affected, but this fix only seems to be for bed blocks? Perhaps it should be expanded to all blocks.

I am for fixing this in general, it is a confirmed mojang bug. But because it is an old one without any we may have reason to make it configurable.

@lynxplay
Copy link
Copy Markdown
Contributor

lynxplay commented Jul 2, 2023

Would also be in favour of hiding this behind a configuration option. Especially with doors, the mechanic of "boosting" yourself by jumping > placing the door > landing partially in the door comes to mind.

@DerEchtePilz
Copy link
Copy Markdown
Contributor

Would also be in favour of hiding this behind a configuration option. Especially with doors, the mechanic of "boosting" yourself by jumping > placing the door > landing partially in the door comes to mind.

I personally wouldn't do that. If Mojang fixed that bug, that "mechanic" would also not exist anymore.
But still, I let the Paper team decide, I've got no power anyway, I just wanted to express my thoughts.

@outlineutils
Copy link
Copy Markdown
Author

Especially with doors, the mechanic of "boosting" yourself by jumping > placing the door > landing partially in the door comes to mind.

This is why I only fixed it for beds

@Owen1212055
Copy link
Copy Markdown
Member

I’m a bit iffy about this, in general this is an imperfect solution and doesn’t cover all blocks like this. May be a better thing to just have as a plugin, or just wait for vanilla to resolve such.

@underscore11code
Copy link
Copy Markdown
Member

Due to this not covering all cases of the original bug, I'm going to close this. Feel free to submit a new PR which fixes all multiblocks (due to the age, putting the fix behind a config option would also be good). Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

7 participants