Added Mushroom spread configuration to world config#9592
Closed
GrayR0ot wants to merge 22 commits into
Closed
Conversation
…mBlock randomTick method
The lists are only supposed to contain ticks for the 1 radius neighbours of the chunk.
lynxplay
requested changes
Aug 10, 2023
Member
|
Yeah, I think in this case an IntOr.DefaultOrDisabled would be nice. I, by far, prefer using words instead of random constants. You never know what might change in the future. Like plenty of I can implement that type if you'd like. Otherwise, just look at how the other ones are implemented and adapt it |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com> Co-authored-by: Bjarne Koll <lynxplay101@gmail.com>
Effect or LevelEvent needs to be replaced but ideally after the enum PR has been merged upstream. Until then, this test and these fixes should address all the known issues with them
Warriorrrr
reviewed
Aug 13, 2023
Comment on lines
+15
to
+17
| - int i = 5; | ||
| + // Paper start - Increase vanilla mushroom spread | ||
| + int mushroomSpreadLimit = world.paperConfig().environment.mushroom.spreadLimit.or(5); |
Member
There was a problem hiding this comment.
Leaving the original i = 5 and using the i as the default in the .or might look a bit cleaner, but generally looks pretty good.
…er into feat/mushroom-spread-config # Conflicts: # patches/server/0005-Paper-config-files.patch
Author
|
I created a new PR with all new changes from Paper/master for better lisibility & workflow on my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update introduces a mushroom configuration to the Paper world, providing users with the ability to bypass the standard vanilla spread limit. This customization allows users to exert more control over mushroom spreading, potentially leading to increased mushroom growth within the designated area.