Fix startup and runtime crashes (experimental branch)#9606
Merged
Machine-Maker merged 5 commits intoAug 15, 2023
Merged
Conversation
- The code with '.getKey().getKey().getKey()' looks a bit strange but is necessary so the results on the timings website are the same as before. It gets the key (String) from the NamespacedKey, of the key from the Keyed, from the key of the Map.Entry.
Warriorrrr
requested changes
Aug 15, 2023
Contributor
|
Isn't the timing stuff subject to be replaced with spark? So any changes to that would be kind of a waste of time. Or not? |
Contributor
Author
Yes it should be replaced in the future as I read, but until it is replaced it should not lead to server crashes. The EntityType change was mainly for the reason that BlockType and EntityType are similiar. |
Machine-Maker
requested changes
Aug 15, 2023
Member
Machine-Maker
left a comment
Machine-Maker
left a comment
There was a problem hiding this comment.
Other than that, looks good.
I skipped the timings stuff cause it is all deprecated, but I didn't realize that it caused a crash so yeah, I guess it should be migrated.
Machine-Maker
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like written on Discord with @Machine-Maker , here the pull request to fix a startup crash and the runtime crash occuring around three minutes after startup, found while wanting to experiment with the
experimentalPaper branch.Changes following things:
java.lang.ClassCastException. While doing this I also migrated the code away from using the deprecated classOldEnum, introduced in the (Craft-)Bukkit pull request for enum to class migration for backwards compatibility, used in theEntityTyperelated code of the timings system.All the code changes were successfully tested through several server startups and several created timings reports (with different worlds and situations).
If i should post pictures of the exceptions, just write and I will post them here.