Fix MC-255756#9649
Conversation
|
Maybe it would be better to both broadcast the entity event and play the sound? |
I chose not to send both because when mojang is gonna fix the issue on their end, we're gonna have a time where the sound is gonna be played twice |
Machine-Maker
left a comment
Machine-Maker
left a comment
There was a problem hiding this comment.
This whole patch can be merged into the patch that fixes a ton of other random vanilla bugs.
Machine-Maker
left a comment
Machine-Maker
left a comment
There was a problem hiding this comment.
I think this bypasses the isSilent check that exists in the regular logic.
The more I look into this specific issue, the less satisfied I am with fixing it on the server. The correct fix is a client-sided one (as illustrated in the mojira issue). There are other inconsistencies we are creating. The sound now has a set seed and has the exact same pitch for all listeners which isn't the case in vanilla.
I think we should just not fix this as it would be too complicated to fix from the server.
There was a problem hiding this comment.
Lets put a // Paper - diff on change on the specific line in LivingEntity#handleEntityEvent that you took the playing sound call from
kennytv
added
the
pre-softspoon: never rebased
7 participants
This PR fixes shields not playing sounds when being broken by an axe or when blocking a damage. This bug is client-sided but can easily be fixed by playing the sounds instead of the entity events, this is exactly what this PR does.