Expand open container api on HumanEntity to support custom titles#9658
Closed
Sytm wants to merge 1 commit into
Closed
Expand open container api on HumanEntity to support custom titles#9658Sytm wants to merge 1 commit into
Sytm wants to merge 1 commit into
Conversation
Machine-Maker
requested changes
Aug 29, 2023
Machine-Maker
requested changes
Sep 15, 2023
Member
Machine-Maker
left a comment
Machine-Maker
left a comment
There was a problem hiding this comment.
We don't have to stick with upstream's ridiculousness in adding redundant public keywords to interface methods. For new methods, just don't include that.
Sytm
changed the title
Contributor
Author
|
Due to the maybe™ upcoming enum eradication I went ahead and removed the internal usage of the Material enum and use the blocks directly |
The methods now take an optional adventure component that overrides the title of the container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods now take an optional component that overrides the title of the container.
I tested these changes with every method and every container type accepts the new overridden title just fine with the villager / merchant being the exception because the level of the villager is appended to the name