Skip to content

Fix sign update desync#9695

Closed
ScriptLineStudios wants to merge 1 commit into
PaperMC:masterfrom
ScriptLineStudios:Fix-sign-update-desync
Closed

Fix sign update desync#9695
ScriptLineStudios wants to merge 1 commit into
PaperMC:masterfrom
ScriptLineStudios:Fix-sign-update-desync

Conversation

@ScriptLineStudios
Copy link
Copy Markdown

Stops desync (most likely caused by latency) in the event of a player updating a block which the server hasn't recognized as a sign.

@ScriptLineStudios ScriptLineStudios requested a review from a team as a code owner September 9, 2023 14:27
@Warriorrrr
Copy link
Copy Markdown
Member

Do you have any link to a place this issue you're fixing has been reported at and/or reproduction instructions? As it stands, this PR has a few issues which makes it not mergable:

  • Sending a block entity update packet doesn't do anything in terms of desync
  • This will cause an NPE if there is no block entity where the client thinks there is one
  • There is no range check done

@Owen1212055
Copy link
Copy Markdown
Member

Closing this as in general it's not really certain what you are trying to fix here. Feel free to respond with a more detailed description of your changes, but it's not really understood what kind of "desync" this is resolving here.

@ScriptLineStudios ScriptLineStudios deleted the Fix-sign-update-desync branch October 29, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants