Compression level change, speeds up compression speeds.#9703
Closed
PedroMPagani wants to merge 1 commit into
Closed
Compression level change, speeds up compression speeds.#9703PedroMPagani wants to merge 1 commit into
PedroMPagani wants to merge 1 commit into
Conversation
kennytv
requested changes
Sep 10, 2023
Member
kennytv
left a comment
kennytv
left a comment
There was a problem hiding this comment.
This should be merged into the original patch 0706-Use-Velocity-compression-and-cipher-natives.patch, ideally adding a config option for the compression level with the default staying -1 as the middle ground between performance and compression level
Author
|
I don't have much time to do this and I also haven't touched much of the patch system, if anyone else who wants to become a contributor of the project wants to take this on, feel free to do the required changes ;) |
Member
|
Superseded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are free to benchmark this on your own, this benchmark from my part was done on DonutSMP events, that get around 700-800 players in a close 400x400 area where there's a lot of Crystal PVP everywhere, lots of chunk interactions etc, compression is highly necessary on environments like this, and a few servers also use this, it's a quick change and most users shouldn't ever feel any need to have this changed but it's a good software improvement if you confirm this should be applied.
This made a buffer compression of around 40kb to 25kb just with little difference from -1, and with MUCH faster speeds.