Skip to content

Ensure destination is unloaded when preventing movement into unloaded chunks.#9717

Closed
pseudospace0 wants to merge 1 commit into
PaperMC:masterfrom
pseudospace0:Ensure-destination-chunk-is-unloaded-when-preventing-movement-into-unloaded-chunks
Closed

Ensure destination is unloaded when preventing movement into unloaded chunks.#9717
pseudospace0 wants to merge 1 commit into
PaperMC:masterfrom
pseudospace0:Ensure-destination-chunk-is-unloaded-when-preventing-movement-into-unloaded-chunks

Conversation

@pseudospace0
Copy link
Copy Markdown

When preventing players from moving into unloaded chunks; I would argue that if a scenario arises where the player is attempting to move to a chunk which is indeed loaded, but is sandwiched between a one or more unloaded chunks it would be more beneficial for the method to return in a place where a warning message is explicitly logged rather than just silently not allowing the movement.

This can be done by ensuring that the location of the movement resides in an unloaded chunk.

@pseudospace0 pseudospace0 requested a review from a team as a code owner September 12, 2023 14:55
@lynxplay
Copy link
Copy Markdown
Contributor

No comment from me on this PR, There is no reports of this actually happening, I don't see a point of "fixing" such a hypothetical.

@pseudospace0
Copy link
Copy Markdown
Author

No comment from me on this PR, There is no reports of this actually happening, I don't see a point of "fixing" such a hypothetical.

I wouldn't really refer to it as a "fix" per say, more just a slightly more elegant way of handling things. I would imagine a scenario like this would most likely arise out of a client using some form of movement hacking in which case it would probably be better to log as either "Player moved too fast" or "Player moved wrongly" rather than just returning silently.

@lynxplay
Copy link
Copy Markdown
Contributor

I disagree that allowing clients to seemingly teleport through unloaded chunks is a more elegant way of handling this than the current implementation.

I don't think we are interested in this fix, I hope you can understand where we are coming from here as this is a non issue you are trying to fix.

Thanks non the less!

@lynxplay lynxplay closed this Sep 13, 2023
@pseudospace0 pseudospace0 deleted the Ensure-destination-chunk-is-unloaded-when-preventing-movement-into-unloaded-chunks branch September 13, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants