Fix strikeLightningEffect powers lightning rods and clears copper alternative#9847
Closed
notTamion wants to merge 1 commit into
Closed
Conversation
notTamion
deleted the
fix-strikelightningeffect-powers-rods-and-clears-copper-alternative
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #9736
This is an alternative to #9780
I personally find the other PR better since it also resolves confusing naming and also doesn't use isSilent of which the current behavior is unintended (and the only api that uses this boolean is deprecated)
But incase paper team thinks this is a better fix i will just open this pr