Fix enchantable brush#9880
Closed
LaylaSilbernberg wants to merge 4 commits into
Closed
Conversation
Member
|
For starting the PR is good handle the main issue, also i recommed you try to edit the original patch where this Tags was added. you can check here https://github.com/PaperMC/Paper/blob/master/CONTRIBUTING.md#modifying-patches for know how to edit a patch. |
Member
|
My original comment generally showcased that there was a bunch of stuff missing from the enchantables set which should also be added |
Contributor
Author
|
Oh I feel very silly, I felt like I was missing something obvious. I will have a look at these things tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should do the trick. I also want to add some tests but I need some more familiarity with the structure of paper so might need some help there.