Add Llama caravan events#9890
Closed
SplotyCode wants to merge 1 commit into
Closed
Conversation
Machine-Maker
requested changes
Oct 30, 2023
Comment on lines
+70
to
+88
| + // Paper start | ||
| + @Override | ||
| + public org.bukkit.craftbukkit.entity.CraftLlama getBukkitEntity() { | ||
| + return (org.bukkit.craftbukkit.entity.CraftLlama) super.getBukkitEntity(); | ||
| + } | ||
| + // Paper end | ||
| + |
Member
There was a problem hiding this comment.
Not sure this is worth not just having 2 casts when the llama is passed to the event constructor. I don't think we do this for other similar situations.
Contributor
Author
There was a problem hiding this comment.
I dont really have a strong opinion on this. In our CraftLlama we could then also remove some casts and for plugin devs it is always tedious to use ((X) ((CraftX) x).getHandle()).methodCall()
We can also use casts but even with var it looks quite ugly using the fqn. Do you have fears of merge conflicts with upstream?
SplotyCode
force-pushed
the
llama-events
branch
2 times, most recently
from
bf363e1 to
c9c18e6
Compare
SplotyCode
force-pushed
the
llama-events
branch
from
c9c18e6 to
443a912
Compare
kennytv
added
the
pre-softspoon: never rebased
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.