Add ChunkStatusChangeEvent

[Cryptite]

Chunk Statuses are a wily thing, but it is nice to know when the state of one changes for concept like lazy-loading, etc.

I'm not sure this event should ever be anything other than read-only but this basic version has worked well for me for awhile.

[Owen1212055]

Cant we use Chunk$LoadLevel?

[electronicboy]

kinda, but they messed up the order of them so it breaks the nice ordinal thing

[Cryptite]

Yeah, was nice for the isUpgrade() method

[notTamion]

wrong package. you are missing a /event. i think this could go into io.papermc.paper.event.world or a sub-package of that

[Cryptite]

Whoops

[Spottedleaf]

The event is fired incorrectly. The chunk system changes the chunk status incrementally, and carefully handles concurrent requests to lower it. It is possible that the overall result of the operation is to lower the status, even if initially it was requested to be higher. You can see this by how the function updateCurrentState works.

You should look more carefully at the operations done in each status change to determine where to place the event. In general this area of code is the worst part of the chunk system and needs to be refactored, so it may not be possible to actually place an event in there without causing issues.

[Cryptite]

The event is fired incorrectly. The chunk system changes the chunk status incrementally, and carefully handles concurrent requests to lower it. It is possible that the overall result of the operation is to lower the status, even if initially it was requested to be higher. You can see this by how the function updateCurrentState works.

You should look more carefully at the operations done in each status change to determine where to place the event. In general this area of code is the worst part of the chunk system and needs to be refactored, so it may not be possible to actually place an event in there without causing issues.

I do see lower in handleFullStatusChange() that nextState is captured for subsequent potential status changes. Might be sufficient to just lower the event to after that that nextState.isOrAfter(currState) check? nextState isn't even used in that method otherwise...

[rayanbzd]

Hello, does any change are needed for this before being merged ? If yes, i can take time to do it.