Trigger resourcepack callbacks#1809
Conversation
This targets the long-lost PaperMC#1369 issue.
|
This would hold callbacks for packs that don't get a terminal client response for as long as the client is connected, right? |
|
Could also be an idea to add a I also thought about marking the Velocity one as obsolete but the Adventure one for example doesn't use the same enum order as Velocity & Minecraft, which would make handling the packet more annoying if we'd replace the Velocity one in the future. |
Do you think it's better to add a timeout to this? What if the client is just really slow though, downloading a 50MB resource pack on a 1mbit/s connection |
Yea I'm not sure, one of the maintainers might have an idea |
Are clients able to trigger this flow, of adding a resource pack & thus registering a callback? I don't think so but I might be wrong. If we can only trigger a callback being registered through a plugin, I don't think this is really a cause for concern. The lifetime of the map (and its entries if the client never responds) is only as long as the client is connected, worst case we're storing a couple stale entries but that buys us having compatibility with slow clients. |
This targets the long-lost #1369 issue.