Skip to content

Trigger resourcepack callbacks#1809

Open
R00tB33rMan wants to merge 1 commit into
PaperMC:dev/3.0.0from
GemstoneGG:velocity/rp-callbacks
Open

Trigger resourcepack callbacks#1809
R00tB33rMan wants to merge 1 commit into
PaperMC:dev/3.0.0from
GemstoneGG:velocity/rp-callbacks

Conversation

@R00tB33rMan
Copy link
Copy Markdown
Contributor

This targets the long-lost #1369 issue.

This targets the long-lost PaperMC#1369 issue.
@Timongcraft
Copy link
Copy Markdown
Contributor

This would hold callbacks for packs that don't get a terminal client response for as long as the client is connected, right?

@Timongcraft
Copy link
Copy Markdown
Contributor

Could also be an idea to add a status() method for the event to promote the adventure status.

I also thought about marking the Velocity one as obsolete but the Adventure one for example doesn't use the same enum order as Velocity & Minecraft, which would make handling the packet more annoying if we'd replace the Velocity one in the future.

@WouterGritter
Copy link
Copy Markdown
Contributor

This would hold callbacks for packs that don't get a terminal client response for as long as the client is connected, right?

Do you think it's better to add a timeout to this? What if the client is just really slow though, downloading a 50MB resource pack on a 1mbit/s connection

@Timongcraft
Copy link
Copy Markdown
Contributor

This would hold callbacks for packs that don't get a terminal client response for as long as the client is connected, right?

Do you think it's better to add a timeout to this? What if the client is just really slow though, downloading a 50MB resource pack on a 1mbit/s connection

Yea I'm not sure, one of the maintainers might have an idea

@WouterGritter
Copy link
Copy Markdown
Contributor

Yea I'm not sure, one of the maintainers might have an idea

Are clients able to trigger this flow, of adding a resource pack & thus registering a callback? I don't think so but I might be wrong.

If we can only trigger a callback being registered through a plugin, I don't think this is really a cause for concern. The lifetime of the map (and its entries if the client never responds) is only as long as the client is connected, worst case we're storing a couple stale entries but that buys us having compatibility with slow clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants