WIP: Unix domain socket binding support#422
Closed
hugmanrique wants to merge 2 commits intoPaperMC:dev/1.1.0from
Closed
WIP: Unix domain socket binding support#422hugmanrique wants to merge 2 commits intoPaperMC:dev/1.1.0from
hugmanrique wants to merge 2 commits intoPaperMC:dev/1.1.0from
Conversation
Contributor
|
I actually already did this in Velocity 2.0.0: b003890 I'd be fine with you backporting this. |
Contributor
Author
|
Ughh, I hate myself for not looking on the 2.0 branch. API changes like b003890#diff-9045d615f487de57c8df1f7e008486d03740e5051247b1b9007e8d15f42f2eccL18 are not possible in minor versions, so will have to wait. |
Contributor
|
Fair enough. I will need to find some time to forward-port all the recent Velocity 1.1.x changes to the 2.0.0 branch. At the same time I'm going to try and rein in all the changes planned for 2.0.0. |
|
I hope your UNIX Socket method is used for the following configuration [servers]
# Configure your servers here. Each key represents the server's name, and the value
# represents the IP address of the server to connect to.
lobby01 = "tcp:127.0.0.1:30066"
lobby02 = "unix:/tmp/mcs-lobby.sock"In addition, Paper server needs this support or other servers need to load additional plugins and support disabling the original game port |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A niche feature, but useful for upper-level proxies running on the same host, e.g. HAProxy (which Velocity already supports). I followed the Redis configuration convention, where the binding address and Unix domain socket address are different options. Mixing both types of sockets under the
bindconfig would complicate determining if the given address is a hostname or a filename.