Skip to content

Add passthrough-default-server-ping option#643

Open
BBaoVanC wants to merge 1 commit into
PaperMC:dev/3.0.0from
BBaoVanC:add-passthrough-default-server-ping
Open

Add passthrough-default-server-ping option#643
BBaoVanC wants to merge 1 commit into
PaperMC:dev/3.0.0from
BBaoVanC:add-passthrough-default-server-ping

Conversation

@BBaoVanC
Copy link
Copy Markdown
Contributor

If passthrough-default-server-ping is set to false, then Velocity will respond with its own MOTD and version for pings that go to a host not listed in forced-hosts. This means that you can make it so Velocity has its own generic network-wide MOTD which is shown on the proxy's main IP(s), but also see the backend's MOTD and version if connecting to it specifically (using a forced host).

This option doesn't have any effect if ping-passthrough is disabled.

@astei astei added the type: feature New feature or request label Feb 19, 2022
@BBaoVanC BBaoVanC force-pushed the add-passthrough-default-server-ping branch from 5c057da to 77e01fe Compare March 13, 2022 04:22
@BBaoVanC
Copy link
Copy Markdown
Contributor Author

Rebased because of the addition of enablePlayerAddressLogging, I think this is ready for review

@BBaoVanC BBaoVanC force-pushed the add-passthrough-default-server-ping branch from 77e01fe to 933ce76 Compare May 7, 2022 23:21
@BBaoVanC BBaoVanC force-pushed the add-passthrough-default-server-ping branch 2 times, most recently from 1bd412a to 820df23 Compare June 10, 2022 23:34
@JT122406
Copy link
Copy Markdown

Can conflicts be resolved and then this merged this would be a great feature

@BBaoVanC
Copy link
Copy Markdown
Contributor Author

Would be nice to know if this has a chance at being merged directly to Velocity (I hope it can) first, before I spend time rebasing it but yes

@Xernium
Copy link
Copy Markdown
Contributor

Xernium commented Nov 14, 2022

I’m putting this, and any other PR that changes something in the config, on hold. We absolutely need a config rewrite before this gets merged. Changes like this to the old system are simply unsustainable now

@JT122406
Copy link
Copy Markdown

I’m putting this, and any other PR that changes something in the config, on hold. We absolutely need a config rewrite before this gets merged. Changes like this to the old system are simply unsustainable now

Any idea when this rewrite will happen for the config

@BBaoVanC BBaoVanC force-pushed the add-passthrough-default-server-ping branch from 820df23 to 5854a65 Compare December 27, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants