Remove Empty Packet check - Finding a real workaround

[linsaftw]

I dont know the reason Empty Packet was originally added, but if i recall correctly it is Exploit related.

This check does nothing but break some clients as you can spam any other packet that doesnt explicitly do a .close() & .flush() and it will break all the netty threads preventing anyone from joining the server.

I disabled this on FlameCord and didn't found any issues.

[mikroskeem]

You mean this patch?

That's not for "exploit" prevention, it's there because vanilla server is able to handle empty packets fine while BungeeCord kicks player because of it.

[mikroskeem]

Or rather... vanilla client, not server. When server sends out an empty packet for some reason (that seems to happen with some weird plugin combinations) then proxy<->server connection simply gets dropped because of an exception.

[linsaftw]

For some reason this doesnt seem to happen with FlameCord. Weird. Maybe i fixed it without noticing? It doesnt seem to be crashing players.

I will close this because it seems that some people might have issues with empty packets. So people without issues just have to allow empty packets.

[Leymooo]

might have issues with empty packets
I think will be better to use separate VarInt And Packet decoder (extend with override read method) for server <--> proxy with empty packet fix, and for player <--> proxy use original decoders to avoid any potential exploits with packets which are without readable bytes.

[linsaftw]

Reopen to support the idea above this message. (If possible)

[electronicboy]

same conclusion I came to on my end before I nodded off last night, but yea, this patch was nothing to do with exploit prevention, but to dull the behavioral difference of bad plugins, people assume that just because it's not kicking a direct connection to the server that something on the server isn't being bad

[linsaftw]

same conclusion I came to on my end before I nodded off last night, but yea, this patch was nothing to do with exploit prevention, but to dull the behavioral difference of bad plugins, people assume that just because it's not kicking a direct connection to the server that something on the server isn't being bad

Agree. Its pretty random and you can't really notice.