Fix some forge plugin message packets not being forwarded correctly#156
Merged
Conversation
Contributor
|
I'm happy to merge this ASAP, /but/ has this been tested? |
Contributor
Author
|
Yep. I've been testing this heavily locally. |
Contributor
|
Alright let's get this merged! |
Contributor
Author
|
Thank ye kindly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue where the Register Dimension packet was not being sent from Waterfall, as the code that handled the FML handshake blocked all packets from being sent on once the handshake was deemed to be complete. This prevented Forge clients from logging into worlds where the dimension ID was not a vanilla one - they just hung on the logging in phase (with exceptions being spammed in the client log).
This fix relaxes the handler to continue to allow FORGE plugin messages through when the handshake is complete/done, allowing this register message to get through to the client correctly.
This fixes #155, see SpongePowered/SpongeForge#1507