Make cmd-server module messages more configurable#422
Conversation
HexedHero
approved these changes
Aug 25, 2019
Contributor
|
This would likely get approved by bungeecord itself. |
Author
I didn't think about that. I'm gonna close this PR for now and reopen it if BungeeCord doesn't accept a similar PR for some reason. |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is but a small change to the existing module (cmd-server) that would make a server list message more configurable. There are a lot of servers (including my own) that use this module to provide an easy way to change servers. While the module itself is really small and fast, it doesn't offer a full way to change the server list message. With this PR accepted people will be able to fully customize the message (including message after the end of the list and possibility to have different colors on comma or servers after the first one) without having to edit the source code.
There are people out there that want to make their in-game messages as perfect as possible, and this PR will help them achieve this.
The change itself doesn't impact the performance at all.