Add missing permission nodes#503
Closed
mikroskeem wants to merge 1 commit into
Closed
Conversation
Contributor
|
not a fan of adding a permission node to /bungee - all it provides is security by obscurity while making waterfall less popular |
Contributor
Author
|
I mean people can already do that with |
Contributor
|
But if you add permission node, default behaviour changes. |
Contributor
Author
|
Sure, might reconsider dropping /bungee from this patch. What about /perms? In my opinion it's pretty useless if you have custom permissions plugin (handling permission checks via an event) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to put /bungee and /perms behind permission nodes