Allow customisation of the Mojang auth url#550
Merged
Conversation
Member
|
Being perfectly honest, I can understand the desire for this, the nature of just slapping it in a config option is where I eer a bit |
Contributor
|
I think the vanilla way for this is to use a proxyselector |
Member
|
Agree with cat on this, should be a command-line option/property imo. I can see users mistakenly touching that in the config. Also, why aren't you just using |
Contributor
Author
|
Have moved this to a system property and switched to |
electronicboy
approved these changes
Jul 21, 2020
JRoy
approved these changes
Jul 21, 2020
Contributor
Author
|
bump ;) |
This was referenced Aug 27, 2020
linsaftw
pushed a commit
to ArkFlame/Waterfall
that referenced
this pull request
Jun 3, 2023
Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Waterfall Changes: 056d668 Allow customisation of the Mojang auth url (PaperMC#550)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have run into situations before where the number of people connections to a proxy at once can sometimes overwhelm certain systems and cause rate limiting from mojangs end.
One of the teams I work for have developed an in house solution to this to load balance Mojang login requests over our internal infrastructure to combat this (which may be open sourced at some point), but to use it we are required to modify this url each time with a custom build.
To keep updating simple (this is like the only thing we have in out fork) and because I'm sure that I am not the first person to run into this I figured it would make sense to be an official patch.