Skip to content

Allow customisation of the Mojang auth url#550

Merged
electronicboy merged 3 commits into
PaperMC:masterfrom
theminecoder:auth-url
Aug 13, 2020
Merged

Allow customisation of the Mojang auth url#550
electronicboy merged 3 commits into
PaperMC:masterfrom
theminecoder:auth-url

Conversation

@theminecoder
Copy link
Copy Markdown
Contributor

I have run into situations before where the number of people connections to a proxy at once can sometimes overwhelm certain systems and cause rate limiting from mojangs end.

One of the teams I work for have developed an in house solution to this to load balance Mojang login requests over our internal infrastructure to combat this (which may be open sourced at some point), but to use it we are required to modify this url each time with a custom build.

To keep updating simple (this is like the only thing we have in out fork) and because I'm sure that I am not the first person to run into this I figured it would make sense to be an official patch.

@electronicboy
Copy link
Copy Markdown
Member

Being perfectly honest, I can understand the desire for this, the nature of just slapping it in a config option is where I eer a bit

@Janmm14
Copy link
Copy Markdown
Contributor

Janmm14 commented Jul 21, 2020

I think the vanilla way for this is to use a proxyselector

@JRoy
Copy link
Copy Markdown
Member

JRoy commented Jul 21, 2020

Agree with cat on this, should be a command-line option/property imo. I can see users mistakenly touching that in the config.

Also, why aren't you just using %s in the URL so you can use String#format. I don't understand the need for your own variables here.

@theminecoder
Copy link
Copy Markdown
Contributor Author

Have moved this to a system property and switched to String#format.

@theminecoder
Copy link
Copy Markdown
Contributor Author

bump ;)

@electronicboy electronicboy merged commit 056d668 into PaperMC:master Aug 13, 2020
@theminecoder theminecoder deleted the auth-url branch August 13, 2020 20:16
linsaftw pushed a commit to ArkFlame/Waterfall that referenced this pull request Jun 3, 2023
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Waterfall Changes:
056d668 Allow customisation of the Mojang auth url (PaperMC#550)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants