Add a command to view all plugins on the proxy#642
Closed
Findus642 wants to merge 3 commits into
Closed
Conversation
Findus642
changed the title
Author
|
Wrote the commit name wrong- it shows all plugins not commands :( |
Janmm14
reviewed
May 20, 2021
Janmm14
reviewed
May 20, 2021
Contributor
Amend & force push to fix |
Author
|
All above should be resolved now with the suggestions implemented |
electronicboy
requested changes
May 20, 2021
| new file mode 100644 | ||
| index 00000000..0a8cd585 | ||
| --- /dev/null | ||
| +++ b/proxy/src/main/java/net/md_5/bungee/command/CommandPlugins.java |
Member
There was a problem hiding this comment.
Should probably be in the waterfall package and in a separate module
…Cord message components (Marked TODO for Adventure)
Janmm14
suggested changes
May 21, 2021
| for (Plugin plugin : plugins) { | ||
| if (!firstIteration) { | ||
| - builder.append(ChatColor.WHITE).append(", "); | ||
| + component.addExtra(ChatColor.WHITE + ", "); |
Contributor
There was a problem hiding this comment.
This is incorrect usage of BungeeCord's Chat API.
Please actually use the ComponentBuilder.
| } | ||
|
|
||
| - builder.append(ChatColor.GREEN).append(plugin.getDescription().getName()); | ||
| + component.addExtra(ChatColor.GREEN + plugin.getDescription().getName()); |
Author
|
All the above has been noted- I'm going to have to reopen this however as I somehow broke my repository (locally) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although not useful for everyone, it can have a purpose.
The command simply shows what plugins are active on the proxy, in the same way as
/pluginsdoes on Bukkit. It would be useful for developers that might not be able to view a full console (due to line limits with hosts) to see if their plugin has been loaded/enabled. It can also be used by owners to see if a plugin has loaded or to see what plugins are installed without having to access files directly.