Skip to content

Add allowedInKey(char) method to check character validity for keys#1286

Closed
NonSwag wants to merge 2 commits into
PaperMC:main/4from
NonSwag:feat/allowed-in-key
Closed

Add allowedInKey(char) method to check character validity for keys#1286
NonSwag wants to merge 2 commits into
PaperMC:main/4from
NonSwag:feat/allowed-in-key

Conversation

@NonSwag
Copy link
Copy Markdown

@NonSwag NonSwag commented Aug 12, 2025

Also fixed javadoc parameter names

@kezz
Copy link
Copy Markdown
Member

kezz commented Oct 6, 2025

Can you explain the use-case for this? I'm not sure if it makes sense as a method given whether a character is allowed depends on where in the key it is used.

@kezz kezz added type: enhancement area: key status: needs discussion An issue or PR that requires design decisions or further consensus building before it can be merged labels Oct 6, 2025
@NonSwag
Copy link
Copy Markdown
Author

NonSwag commented Oct 6, 2025

My use case is/was in a StringReader for a custom argument type, but I guess you are right, maybe parsing the key would be smarter
image

@NonSwag NonSwag closed this by deleting the head repository Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: key status: needs discussion An issue or PR that requires design decisions or further consensus building before it can be merged type: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants