Skip to content

api: Rename Title.Times.of#449

Merged
zml2008 merged 3 commits into
PaperMC:masterfrom
NoahvdAa:feature/rename-times-of
Sep 25, 2021
Merged

api: Rename Title.Times.of#449
zml2008 merged 3 commits into
PaperMC:masterfrom
NoahvdAa:feature/rename-times-of

Conversation

@NoahvdAa

Copy link
Copy Markdown
Member

Fixes #448.

@NoahvdAa NoahvdAa changed the title api: Rename Title.Times.of (#448) api: Rename Title.Times.of Sep 21, 2021

@kezz kezz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This PR should however also replace all usages of the now deprecated method in the codebase.

Comment thread api/src/main/java/net/kyori/adventure/title/Title.java
@NoahvdAa NoahvdAa requested a review from kezz September 21, 2021 15:02
Comment thread api/src/main/java/net/kyori/adventure/title/Title.java Outdated

@kezz kezz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)

@kezz kezz added this to the 4.10.0 milestone Sep 22, 2021
@zml2008 zml2008 merged commit 71061df into PaperMC:master Sep 25, 2021
@zml2008 zml2008 self-assigned this Sep 25, 2021
This was referenced Feb 28, 2022
This was referenced Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename Title.Times.of

4 participants