Conversation
Camotoy
approved these changes
Oct 21, 2021
Contributor
There was a problem hiding this comment.
Seems like a clientbound chat message packet would cause a null pointer error on Minecraft 1.17.1 (meaning it's fully justified as a thing in Adventure). So, having this option as a sane API way to check for controlled null packets, this works for our use-case.
kezz
requested changes
Oct 24, 2021
kezz
left a comment
kezz
left a comment
Member
There was a problem hiding this comment.
Could we have a unit test for this that references the linked issue?
zml2008
approved these changes
Dec 11, 2021
This was referenced Feb 28, 2022
Merged
Merged
Merged
This was referenced Feb 28, 2022
Merged
Merged
Merged
Merged
This was referenced Mar 14, 2022
This was referenced Apr 13, 2022
This was referenced May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.