feat(api): Add possibility of using Component#join with a root style#653
Merged
zml2008 merged 3 commits intoPaperMC:main/4from Apr 26, 2022
Merged
feat(api): Add possibility of using Component#join with a root style#653zml2008 merged 3 commits intoPaperMC:main/4from
zml2008 merged 3 commits intoPaperMC:main/4from
Conversation
kezz
requested changes
Dec 22, 2021
KingOfSquares
force-pushed
the
join-with-rootstyle
branch
from
6296d98 to
519253f
Compare
KingOfSquares
force-pushed
the
join-with-rootstyle
branch
from
519253f to
fb00066
Compare
kezz
requested changes
Jan 2, 2022
Member
kezz
left a comment
kezz
left a comment
There was a problem hiding this comment.
Lots of docs nitpicks here and a minor change for the single element join method. This is a very good change though!
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfigurationImpl.java
Outdated
Show resolved
Hide resolved
KingOfSquares
force-pushed
the
join-with-rootstyle
branch
from
fb00066 to
99b3047
Compare
kezz
requested changes
Feb 13, 2022
Member
kezz
left a comment
kezz
left a comment
There was a problem hiding this comment.
Style needs to be added to the toString output
KingOfSquares
force-pushed
the
join-with-rootstyle
branch
from
99b3047 to
7be2574
Compare
kezz
approved these changes
Mar 30, 2022
Member
kezz
left a comment
kezz
left a comment
There was a problem hiding this comment.
Needs since tags updating, but otherwise LGTM!
KingOfSquares
force-pushed
the
join-with-rootstyle
branch
from
d6f30f7 to
75fcd6b
Compare
zml2008
approved these changes
Apr 26, 2022
zml2008
force-pushed
the
join-with-rootstyle
branch
from
75fcd6b to
567a278
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #505