MiniMessage: Handle arguments for PreProcessTags correctly#735
Merged
zml2008 merged 2 commits intoPaperMC:main/4from Apr 15, 2022
Merged
MiniMessage: Handle arguments for PreProcessTags correctly#735zml2008 merged 2 commits intoPaperMC:main/4from
zml2008 merged 2 commits intoPaperMC:main/4from
Conversation
4 tasks
zml2008
approved these changes
Apr 2, 2022
kezz
approved these changes
Apr 3, 2022
kezz
previously requested changes
Apr 3, 2022
Member
kezz
left a comment
kezz
left a comment
There was a problem hiding this comment.
Docs in PreProcess need updating to specify that they can accept arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #732
The tests should be a good example how to use arguments in pre process tags.
Currently the code looks a little bit ugly. Maybe use the first token from the childTokens? Or something else.