Skip to content

Conversation

@olijeffers0n
Copy link
Member

@olijeffers0n olijeffers0n commented Jan 13, 2024

image

Adds a script generator for starting your server.

closes #260

Copy link
Member

@MiniDigger MiniDigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a copy to clipboard button would be cool

@Leguan16
Copy link
Contributor

a copy to clipboard button would be cool

maybe copy by clicking the script box?

@pop4959
Copy link
Member

pop4959 commented Jan 13, 2024

Yeah I think you could get away with putting a copy to clipboard symbol somewhere around there and just making all of it clickable

@powercasgamer
Copy link
Contributor

There should probably also be some error handling in the file name box so you don't end up nothing there?

@pop4959
Copy link
Member

pop4959 commented Jan 14, 2024

There should probably also be some error handling in the file name box so you don't end up nothing there?

Maybe just keep server.jar as a placeholder for the field and if they don't enter it use that as the default, perhaps?

@olijeffers0n
Copy link
Member Author

There should probably also be some error handling in the file name box so you don't end up nothing there?

Maybe just keep server.jar as a placeholder for the field and if they don't enter it use that as the default, perhaps?

The server.jar is the default value in the State, which results in it being inside the box and not just a placeholder. I will add validation though and default to server.jar


const FLAGS: { [key: string]: FlagType } = {
AIKARS: {
label: 'Aikar\'s',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate how inconsistent the usage of " and ' is in this file, do we have editor config or eslint or prettier or whatever to enforce one? lol

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, yeah. I've changed this file for now. In the future id like to have some sort of formatting checker and also a British checker for me :P

@olijeffers0n olijeffers0n merged commit aca1d34 into main Jan 20, 2024
@olijeffers0n olijeffers0n deleted the feat/add-startup-script-creation branch January 20, 2024 20:17
sowelipililimute pushed a commit to sowelipililimute/docs that referenced this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated information

8 participants