Skip to content

Fix wrong version reference in API call#328

Closed
delath wants to merge 1 commit into
PaperMC:mainfrom
delath:patch-1
Closed

Fix wrong version reference in API call#328
delath wants to merge 1 commit into
PaperMC:mainfrom
delath:patch-1

Conversation

@delath
Copy link
Copy Markdown

@delath delath commented Mar 27, 2024

MINECRAFT_VERSION="1.20.4" is surely a copy/paste oversight, we need to obtain the build of the LATEST_VERSION and not of the MINECRAFT_VERSION, in the next steps we are rightfully referring only to the LATEST_VERSION.

MINECRAFT_VERSION="1.20.4" is surely a copy/paste oversight, we need to obtain the build of the LATEST_VERSION and not of the MINECRAFT_VERSION, because in the next steps we are rightfully referring only to the LATEST_VERSION.
@zlataovce
Copy link
Copy Markdown
Member

in my opinion, it should rather use MINECRAFT_VERSION to match the example's description and the latest version query should be extracted into another example

@olijeffers0n
Copy link
Copy Markdown
Member

Hi! Thank you for opening this PR, however this was not the intention we had behind this example. As @zlataovce said, this is technically correct as-is, however this latest version query should be a different example. If you would like to work on this, please open another PR! 😄

@delath
Copy link
Copy Markdown
Author

delath commented Mar 30, 2024

Hi! Thank you for opening this PR, however this was not the intention we had behind this example. As @zlataovce said, this is technically correct as-is, however this latest version query should be a different example. If you would like to work on this, please open another PR! 😄

He didn't say that this is correct as-is, because it's not, however i think he is right and there should be two different examples, i may work on this when i have time.

sowelipililimute pushed a commit to sowelipililimute/docs that referenced this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants